<html>
<head><meta charset="utf-8"><title>Review request #71006 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Review.20request.20.2371006.html">Review request #71006</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="194876457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Review%20request%20%2371006/near/194876457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Review.20request.20.2371006.html#194876457">(Apr 22 2020 at 00:05)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116083">@pnkfelix</span>, <a href="https://github.com/rust-lang/rust/issues/71006" title="https://github.com/rust-lang/rust/issues/71006">#71006</a>, the backward dataflow PR, is waiting on your review. Will you get to it anytime soon? <span class="user-mention silent" data-user-id="211727">Jonas Schievink</span> would like to use it for a more robust liveness analysis to implement NRVO, and I'd like to do better dead-code elimination.</p>
<p><span class="user-mention silent" data-user-id="211727">Jonas Schievink</span> <a href="#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/Status.20of.20NRVO-like.20optimizations/near/194616042" title="#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/Status.20of.20NRVO-like.20optimizations/near/194616042">said</a>:</p>
<blockquote>
<p>One thing I wanted to play with is a borrow-aware liveness analysis, which is also used by the generator transform, and your dataflow framework changes to support backwards dataflow would help making that simpler, so I'm looking forward to that</p>
</blockquote>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> has signed off in the abstract if that helps. There's a small hack to work around shortcomings of <code>BodyAndCache</code> that can be removed <a href="https://github.com/rust-lang/rust/issues/71044" title="https://github.com/rust-lang/rust/issues/71044">#71044</a> is merged. It's currently in the bors queue.</p>



<a name="194876545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Review%20request%20%2371006/near/194876545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Review.20request.20.2371006.html#194876545">(Apr 22 2020 at 00:06)</a>:</h4>
<p>Sorry yes I know</p>



<a name="194876588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Review%20request%20%2371006/near/194876588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Review.20request.20.2371006.html#194876588">(Apr 22 2020 at 00:07)</a>:</h4>
<p>I’m trying to juggle a lot of stuff. If I don’t get to it by Thursday then we will delegate to someone else, okay?</p>



<a name="194876605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Review%20request%20%2371006/near/194876605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Review.20request.20.2371006.html#194876605">(Apr 22 2020 at 00:07)</a>:</h4>
<p>Sounds good! Thanks.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>